Add share button mapping to Xbox Series X controller on Android#14921
Add share button mapping to Xbox Series X controller on Android#14921slouken merged 1 commit intolibsdl-org:mainfrom
Conversation
|
Did you test that this change enables the share button for Xbox Series X controllers on Android? If so, what versions of Android did you test, and did you test both Bluetooth and USB connections? |
|
@Alex2782 Hello, may I ask if you can test my original Godot PR and see if your controller is fixed there, please? (In my original PR I included this fix and made the Android code read SDL's internal mappings database) Oh I just realized that the code can't convert the required Android button to SDL button id, I will try to fix it! |
Nintorch
force-pushed
the
xbox-series-x-share-button-mapping
branch
from
99ec2e3 to
06019d3
Compare
Done! Alex2782, may I ask if you can test this PR by downloading "SDL-android-arm64-apks.zip" file from this PR's artifacts later and running "testcontroller.apk", please? |
looks good! Test, VideoScreen_recording_20260203_200203.mp4 |
|
Merged, thanks! |
|
Is it intended that this removes the value for AKEYCODE_BUTTON_L2 and assigns the same value for that and AKEYCODE_MEDIA_RECORD in SDL_sysjoystick.c? |
Yes, 15 is the value of MISC1, so it's just adding RECORD and using the more readable symbolic representation of the same value. |
4 participants
Description
It seems that Xbox Series X controller mappings on Android in the internal mappings database (
src/joystick/SDL_gamepad_db.h) don't have a mapping for the Share button. See also godotengine/godot#114338 (comment) .Existing Issue(s)
I haven't found any.